-
Notifications
You must be signed in to change notification settings - Fork 716
[css-values-5] Behavior of ident() in at-rule preludes #12219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349
Seems reasonable to make this valid anywhere that accepts |
This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463950}
This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463950}
In media queries, there is no element context, but we still allow So how about (proposed resoluition): |
This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463950}
Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463976}
Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463976}
Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463976}
Ah, no. It's too much pain for zero (?) benefit. We would then need to parse ~all rules (also style rules, since some selectors can hold custom idents) into some not-fully-resolved form that needs to be (re)computed into a final rule when media values change. I don't see that actually happening. Then I think we should just make |
Additionally, add a basic crash test for @Property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464032}
Additionally, add a basic crash test for @Property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464032}
Additionally, add a basic crash test for @Property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464032}
The problem is not with |
There's several examples beyond |
…tainer-name, Automatic update from web-platform-tests [ident] Support ident() in container/container-name This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463950} -- wpt-commits: 742db34711329e93cc54d6b8b1a3b7eedbe41e65 wpt-pr: 52700 Differential Revision: https://phabricator.services.mozilla.com/D250989
…osition-try, Automatic update from web-platform-tests [ident] Test ident() for @position-try/position-try Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463976} -- wpt-commits: ef521b4f5b6ade5f8315cfdee1f5d289d8a7b4ee wpt-pr: 52719 Differential Revision: https://phabricator.services.mozilla.com/D250991
…stom properties, Automatic update from web-platform-tests [ident] Resolve ident() in registered custom properties Additionally, add a basic crash test for @Property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464032} -- wpt-commits: 85eadd1d77986f1687cf2310c3201ee5f37c1f3a wpt-pr: 52725 Differential Revision: https://phabricator.services.mozilla.com/D251001
…tainer-name, Automatic update from web-platform-tests [ident] Support ident() in container/container-name This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463950} -- wpt-commits: 742db34711329e93cc54d6b8b1a3b7eedbe41e65 wpt-pr: 52700 Differential Revision: https://phabricator.services.mozilla.com/D250989
…osition-try, Automatic update from web-platform-tests [ident] Test ident() for @position-try/position-try Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463976} -- wpt-commits: ef521b4f5b6ade5f8315cfdee1f5d289d8a7b4ee wpt-pr: 52719 Differential Revision: https://phabricator.services.mozilla.com/D250991
…stom properties, Automatic update from web-platform-tests [ident] Resolve ident() in registered custom properties Additionally, add a basic crash test for @Property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464032} -- wpt-commits: 85eadd1d77986f1687cf2310c3201ee5f37c1f3a wpt-pr: 52725 Differential Revision: https://phabricator.services.mozilla.com/D251001
…tainer-name, Automatic update from web-platform-tests [ident] Support ident() in container/container-name This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463950} -- wpt-commits: 742db34711329e93cc54d6b8b1a3b7eedbe41e65 wpt-pr: 52700 Differential Revision: https://phabricator.services.mozilla.com/D250989
…osition-try, Automatic update from web-platform-tests [ident] Test ident() for @position-try/position-try Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "@position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463976} -- wpt-commits: ef521b4f5b6ade5f8315cfdee1f5d289d8a7b4ee wpt-pr: 52719 Differential Revision: https://phabricator.services.mozilla.com/D250991
…stom properties, Automatic update from web-platform-tests [ident] Resolve ident() in registered custom properties Additionally, add a basic crash test for @Property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1464032} -- wpt-commits: 85eadd1d77986f1687cf2310c3201ee5f37c1f3a wpt-pr: 52725 Differential Revision: https://phabricator.services.mozilla.com/D251001
…tainer-name, Automatic update from web-platform-tests [ident] Support ident() in container/container-name This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futharkchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/main{#1463950} -- wpt-commits: 742db34711329e93cc54d6b8b1a3b7eedbe41e65 wpt-pr: 52700 Differential Revision: https://phabricator.services.mozilla.com/D250989 UltraBlame original commit: 6b90a76d04967bec1a2f03eec0c48c3d6106adf5
…sition-try, Automatic update from web-platform-tests [ident] Test ident() for position-try/position-try Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futharkchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/main{#1463976} -- wpt-commits: ef521b4f5b6ade5f8315cfdee1f5d289d8a7b4ee wpt-pr: 52719 Differential Revision: https://phabricator.services.mozilla.com/D250991 UltraBlame original commit: 74dc93c234c75d25adec5b15d0ebfe567a64a164
…stom properties, Automatic update from web-platform-tests [ident] Resolve ident() in registered custom properties Additionally, add a basic crash test for property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Reviewed-by: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/main{#1464032} -- wpt-commits: 85eadd1d77986f1687cf2310c3201ee5f37c1f3a wpt-pr: 52725 Differential Revision: https://phabricator.services.mozilla.com/D251001 UltraBlame original commit: 0d6a6d8af802e9848e14238cab4e67e880ea47bc
…tainer-name, Automatic update from web-platform-tests [ident] Support ident() in container/container-name This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futharkchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/main{#1463950} -- wpt-commits: 742db34711329e93cc54d6b8b1a3b7eedbe41e65 wpt-pr: 52700 Differential Revision: https://phabricator.services.mozilla.com/D250989 UltraBlame original commit: 6b90a76d04967bec1a2f03eec0c48c3d6106adf5
…sition-try, Automatic update from web-platform-tests [ident] Test ident() for position-try/position-try Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futharkchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/main{#1463976} -- wpt-commits: ef521b4f5b6ade5f8315cfdee1f5d289d8a7b4ee wpt-pr: 52719 Differential Revision: https://phabricator.services.mozilla.com/D250991 UltraBlame original commit: 74dc93c234c75d25adec5b15d0ebfe567a64a164
…stom properties, Automatic update from web-platform-tests [ident] Resolve ident() in registered custom properties Additionally, add a basic crash test for property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Reviewed-by: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/main{#1464032} -- wpt-commits: 85eadd1d77986f1687cf2310c3201ee5f37c1f3a wpt-pr: 52725 Differential Revision: https://phabricator.services.mozilla.com/D251001 UltraBlame original commit: 0d6a6d8af802e9848e14238cab4e67e880ea47bc
…tainer-name, Automatic update from web-platform-tests [ident] Support ident() in container/container-name This CL adds support for ident() in the container and container-name properties. Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "container ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I200e8f1c516ebe69e48f97048014c3f65beac349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6574640 Reviewed-by: Rune Lillesveen <futharkchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/main{#1463950} -- wpt-commits: 742db34711329e93cc54d6b8b1a3b7eedbe41e65 wpt-pr: 52700 Differential Revision: https://phabricator.services.mozilla.com/D250989 UltraBlame original commit: 6b90a76d04967bec1a2f03eec0c48c3d6106adf5
…sition-try, Automatic update from web-platform-tests [ident] Test ident() for position-try/position-try Since the behavior within at-rule preludes is not specified [1], this CL just includes a basic crash test for "position-try ident(...)" as a provisional safeguard. [1] w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: If0b7adf6ce68f32d22529f76bc29ab88c72a9aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6573937 Reviewed-by: Rune Lillesveen <futharkchromium.org> Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Cr-Commit-Position: refs/heads/main{#1463976} -- wpt-commits: ef521b4f5b6ade5f8315cfdee1f5d289d8a7b4ee wpt-pr: 52719 Differential Revision: https://phabricator.services.mozilla.com/D250991 UltraBlame original commit: 74dc93c234c75d25adec5b15d0ebfe567a64a164
…stom properties, Automatic update from web-platform-tests [ident] Resolve ident() in registered custom properties Additionally, add a basic crash test for property while we wait for Issue 12219 to resolve. w3c/csswg-drafts#12219 Bug: 384930424 Change-Id: I36c215cac8558dbc964fda366e2ddba3c7b2017a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6578154 Commit-Queue: Anders Hartvoll Ruud <andruudchromium.org> Reviewed-by: Rune Lillesveen <futharkchromium.org> Cr-Commit-Position: refs/heads/main{#1464032} -- wpt-commits: 85eadd1d77986f1687cf2310c3201ee5f37c1f3a wpt-pr: 52725 Differential Revision: https://phabricator.services.mozilla.com/D251001 UltraBlame original commit: 0d6a6d8af802e9848e14238cab4e67e880ea47bc
The spec says:
Does this mean that it's not valid in other contexts? For example:
@position-try ident("--p" 1) {}
. If it is valid, what happens with e.g.@position-try ident("--p" sign(16px - 1em)) {}
? Or@position-try ident("--p" sibling-index()) {}
?@container ident("--p" sign(16px - 1em)) {}
, if valid, would need to resolveem
(etc) against something that's not the container's font-size (unlikeem
in the query itself), since the ident is the thing that determines what to query.The text was updated successfully, but these errors were encountered: